Run `npm run build` to generate `resources.json` during packaging time

brave / brave-core-crx-packager

Mozilla Public License 2.0

41 stars 35 forks source link

Open ShivanKaul opened 2 months ago

ShivanKaul commented 2 months ago

We currently consume resources.json (https://github.com/brave/adblock-resources/blob/master/dist/resources.json) in crx-packager. This requires remembering to run npm run build when adding/editing a resource under resources/ like in https://github.com/brave/adblock-resources/pull/207

We should just run npm run build in crx-packager on the raw resources.

ryanbr commented 2 months ago

My npm build in LTS is 8, which isn't supported :(

antonok-edm commented 2 months ago

@ryanbr what @ShivanKaul is saying is we can run it on the servers, so you won't need any extra steps