search

brave / brave-core-crx-packager

Mozilla Public License 2.0
41 stars 35 forks source link

feat(SmartNTT): support new file name for sponsored images #994

Closed IanKrieger closed 1 month ago

IanKrieger commented 1 month ago

During the development of SmartNTT, we ran into a blocker where we realized that with the addition of conditionMatchers to the wallpapers section of an NTT would not be honored in legacy browsers (1.72.x). This means that a SmartNTT would show to anyone below that version. In order to remedy this, the "quick-fix" idea was to create a new file called si-photo.json. So that way, all new browsers could read the new file, while legacy browsers kept the the same photo.json they were used to, without the SmartNTT present in them (as determined by the ntp-si-assets packager)

tackley commented 1 month ago

We've decided to go with evolving the content of the existing photo.json rather than introducing a new file. There will still need to be a minor change needed here, but it will be much smaller in scope.

This PR can be closed, which I will do as soon as I have access to do so ;)