search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Red icon for HTTPS upgrades #2554

Open jumde opened 4 years ago

jumde commented 4 years ago

Description:

HTTPS-Everywhere and HSTS upgrades show red-icon in the address bar

Steps to Reproduce

  1. Navigate to https-everywhere.badssl.com - Refresh - red icon
  2. Navigate to hsts.badssl.com - Refresh - red icon

Actual result: Red icon in URL bar

Expected result: Secure icon (Grey)

Reproduces how often: [Easily reproduced, Intermittent Issue] Easily

Brave Version: 1.16.2

Device details: iPhone 11

iccub commented 4 years ago

Possibly related https://github.com/brave/brave-ios/pull/1971

Brandon-T commented 3 years ago

Sometimes even after an upgrade, the website is still not secure as it loads insecure scripts still, so webView.hasOnlySecureContent is false. So even though it is https website and upgrade was successful, it doesn’t mean the web-page itself is fully secure.

Further discussion: https://bravesoftware.slack.com/archives/C06UXF3KJ/p1613027526101900