search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Implement password sync #3228

Closed jsecretan closed 2 years ago

jsecretan commented 3 years ago

Problem Description

The iOS browser should sync passwords with Desktop and Android instances of Brave which have the sync feature enabled

Feature Overview

Please refer to the comments for details

  1. https://github.com/brave/brave-ios/issues/3228#issuecomment-909411581
  2. https://github.com/brave/brave-ios/issues/3228#issuecomment-1024484895

Design

We will be using the Design created for https://github.com/brave/brave-ios/pull/4124

Implementation Details

Please refer upcoming iOS PR for details and Test Plan

User Experience

  1. Use Desktop or Android version of Brave and save password for a few sites
  2. Enable sync
  3. Join the sync group from iOS

Additional information

There should be toggles for password on sync screen (on iOS) so user can choose to sync or not sync passwords.

iccub commented 2 years ago

@martinlanger90 can you show us your sync internals page? Go to the sync settings screen and tap on a cog wheel icon in top right

martinlanger90 commented 2 years ago

I tried to clear the sync data on that internals page. Now it works. Will let you know if it comes back.

Other issue: I cannot choose between my logins on my pages where I would need my login credentials?!

iccub commented 2 years ago

@martinlanger90 this is a gap we have to implement, see more at https://github.com/brave/brave-ios/issues/5250

As a workaround you have to copy and pass your credentials manually from the Saved-Logins screen

Apraptor commented 2 years ago

@bsclifton @soner-yuksel I just wanted to thank you again for finally bring password sync to iOS. It has saved me many times already to be able to look up a password from Timbuktu.

There is one qualify of life feature that doesn't seem to be implemented yet, which is to allow any iOS app to tap into the saved passwords. Currently, I still have to double save my passwords to Keychain so that iOS app can access them without having to manually look it up every time. Do you know if this is a feature that can be enabled also?

Thanks again.

soner-yuksel commented 2 years ago

@Apraptor thanks for kind words.

About your question, we have plans to register Brave Application as a Password Manager. We will mention here when we start working on it.

soner-yuksel commented 11 months ago

Btw the Password Manager (Auto-Fill Provider) work will be landing with https://github.com/brave/brave-browser/issues/36028

You can check the status from that issue.