improving animation when closing into card under Brave Today

[kjozwiak]

Description:

When you close the intro card under Brave Today, the entire feeds quickly flashes/disappears and then loads again without the into card. We can probably improve this and make it a smoother experience compared to what we have now.

Steps to Reproduce

1. launch brave (used 1.23 (21.2.10.18) in this case)
2. under a NTP, swipe down so you can see the intro card under Brave Today
3. click/tap on the X to dismiss the intro card (notice the flash/janky animation)

Actual result:

When closing the Brave Today intro card, the feed flashes/disappears quickly before loading without the dismissed intro card.

Expected result:

Should be a smoother experience/animation.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Reproducible 100% of the time using the above STR.

Brave Version:

• Reproduced using 1.23 (21.2.10.18)

Device details:

• iPhone 11 running iOS 14.4 using 1.23 (21.2.10.18) - Reproduced
• iPad Air (3rd Gen) running iOS 14.4 using 1.23 (21.2.10.18) - Reproduced
• iPad Mini 4 running iOS 13.7 using 1.23 (21.2.10.18) - Reproduced
• iPhone 6s+ running iOS 12.4.1 using 1.23 (21.2.10.18) - Reproduced

Website problems only:

• did you check with Brave Shields down? N/A
• did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @karenkliu @srirambv @bsclifton @anthonypkeane

[kjozwiak]

BTW, this is also reproducible under 1.22.2 so it's not a new regression, hence not adding it into the 1.23 milestone.