search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Don't exclude Downloads from backups #3655

Open ViRb3 opened 3 years ago

ViRb3 commented 3 years ago

Description:

I just switched phones, restored my backup, wiped the old phone, just to find that all the files I had downloaded were missing. Looking at this GitHub repo, I found issue #1438 and then PR #1455 that marks the Download folder as excluded from backups.:

https://github.com/brave/brave-ios/blob/a2865d38dd582ff8829c56ca0fe973621e6ae181/Client/FileManagerExtension.swift#L20-L21

May I know why this is the case? I agree that it is my fault for not checking before, but I did not anticipate this "feature". All other browsers such as Safari do not exclude their Downloads from backups. On Safari, the folder can be found under:

Apps\com.apple.mobilesafari\Container\Library\Safari\Downloads

Could the Downloads folder please be included back into backups?

Thanks

Reproduces how often: Always

Brave Version: 1.24(21.4.1.15)

Device details: iPhone 12, iOS 14.5.1

tilfischer commented 1 year ago

The download folder seems to be still excluded from backups for the current iOS version of Brave. Please include if for backups as it is included e.g. for safari.