Closed kjozwiak closed 1 year ago
Quick update: this seems to be happening as far back as 1.24
so it's definitely not a new regression. I can't really go any further due to the 90 day limitation of TF but looks like it's been in Release
for a while.
Believe @kylehickinson mentioned that switching to the iOS 14
API would fix the above issues but we'll need to figure out what to do with iOS 13
which we're still supporting.
I don't believe this is a problem anymore, it was likely fixed a long time ago when we switched APIs (we're also no longer supporting 13)
in progress using version 1.46 (22.12.8.20)
on the following device(s):
iPhone 12 - iOS 16.x iPhone XR - iOS 15.x iPhone X - iOS 14.4.2 iPad - iPadOS 15.x
STR: https://github.com/brave/brave-ios/issues/3772#issue-918131178
Find in Page
are not highlighted after search bar is closed.Find in Page
does not recall previous values or show them highlightediPad | iPhone |
https://user-images.githubusercontent.com/17885425/206782703-7bfb6ff9-537e-4a5c-ac70-a1b82a0fbb50.MP4 | https://user-images.githubusercontent.com/17885425/206782587-ad71baaf-70e2-431b-b111-eeaf4ff9b0ed.MP4 |
Description:
When searching for a string a page using either
On this page
via the omnibox or via theFind in page
under theSettings
menu, pressingX
will close the search bar at the bottom but will leave all instances of the word still highlighted.Steps to Reproduce
the
via the omnibox orFind in page
under theSettings
X
to close the search barthe
are still highlightedActual result:
Example
Example
Expected result:
When you close the search bar at the bottom, all highlighted instances should be removed.
Reproduces how often: [Easily reproduced, Intermittent Issue]
100% reproducible using the above STR.
Brave Version:
1.26 (21.5.28.14)
- Reproduced1.27 (21.6.10.21)
- ReproducedDevice details:
iPhone 11
runningiOS 14.6
- ReproducediPad Air (3rd Gen)
runningiOS 14.5
- ReproducedWebsite problems only:
N/A
N/A