search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Search string is not updated if cursor is not at the end #5262

Closed brogers5 closed 2 years ago

brogers5 commented 2 years ago

Description:

Search strings are not updated if cursor is not at the end of the omnibox

Steps to Reproduce

  1. Type a string within the omnibox.
  2. Move the cursor back within the string.
  3. Type additional characters.

Actual result: Search strings in content pane are not updated.

934BD892-098B-4BBE-A9DC-B9308276C056

The string will not be updated until new characters are typed at the end of the string.

Pressing either of the search buttons in the content pane will use the string as displayed in the button's UI. This is not consistent with the behavior for the keyboard's Go button, which will search using the omnibox's string instead.

Expected result: Search strings should be consistent with the omnibox's contents.

Reproduces how often: Easily reproduced

Brave Version: v1.37 (22.4.6.8)

Device details: iPhone 13 Pro Max (IOS 15.4.1)

Uni-verse commented 2 years ago

Verified using version 1.43 (22.9.2.15)

Test Devices: iPhone 12 Pro & XR| iOS 15.5 iPad (7th Gen) | iOS 15.5 iPhone X | iOS 14.4.2

Using STR in https://github.com/brave/brave-ios/issues/5262#issue-1207494838

IMG_3552