search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 442 forks source link

Provide user friendly display string for the additional filter lists #5885

Open iccub opened 2 years ago

iccub commented 2 years ago

Followup to https://github.com/brave/brave-ios/issues/5729

Those list names we get from brave-core are not localized at all, and their descriptions could be better. Let's try to make those copy localizable and more user friendly.

Video showing how the Additional filter lists are not translated: https://github.com/brave/brave-ios/assets/909331/663962bf-a0c9-4af2-80a1-7fc208315977

AndyAnds265 commented 9 months ago

@iccub - which list are you talking about?

ShivanKaul commented 8 months ago

@iccub this sounds like it should just be a brave-core thing that iOS inherits.

cuba commented 8 months ago

@AndyAnds265 The name should really be "Additional Filter Lists" not "Custom filter lists". We are referring to things like cooke consent or notifications lists. Which have hard coded descriptions and titles coming from a component list.

I don't believe this should be an iOS issue actually as these titles and description are coming from a component and can be handled more globally in brave core.

I included a video showing that our additional filter lists are not translated: https://github.com/brave/brave-ios/assets/909331/663962bf-a0c9-4af2-80a1-7fc208315977