search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 442 forks source link

Re-enable logging on dev builds #6375

Closed Uni-verse closed 2 years ago

Uni-verse commented 2 years ago

Description:

Logging was made private in 1.45 on iOS and this actually blocks QA from verifying that ads/rewards are working as expected.

PR: https://github.com/brave/brave-ios/pull/5969

Steps to Reproduce

  1. Install 1.45 Dev / Debug build
  2. Enable rewards
  3. Monitor brave-core console logs

Actual result: Logs are not shown

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue] Easily

Brave Version: 1.45

Device details: iPhone, iPad

Website problems only:

Additional Information

kjozwiak commented 2 years ago

After discussing with @kylehickinson, @brave/qa-team we'll need to do the following to view the logs via Console.app as it slightly changed as we're now using the system logger’s.

Verification PASSED on iPhone 11 running iOS 16.2 using 1.45 (22.11.11.0)

Receiving the expected amount of unblinded tokens as per the following:

debug   14:10:00.725260-0500    Client  GetSignedTokens
debug   14:10:00.725308-0500    Client  GET /v2/confirmation/token/{paymentId}?nonce={nonce}
debug   14:10:00.924514-0500    Client  OnGetSignedTokens
debug   14:10:00.960580-0500    Client  Added 50 unblinded tokens, you now have 50 unblinded tokens
debug   14:10:00.960642-0500    Client  Successfully refilled unblinded tokens

Received an ad notification as per the following

debug   14:18:09.643548-0500    Client  Opportunity arose to serve a notification ad
debug   14:18:09.643798-0500    Client  Found 6 eligible ads
debug   14:18:09.643836-0500    Client  Served notification ad:
  placementId: fcad579f-614f-4e90-99c0-7b89d6794a87
  creativeInstanceId: 05e598c6-a916-4137-b744-14b0b17b602c
  creativeSetId: 55236e74-74ad-4d33-917c-3260ad7d5a15
  campaignId: 9df9368d-f838-4120-8b98-4f891b49429f
  advertiserId: 8fc94bb9-2ab3-49df-a5a7-8ee680384dec
  segment: untargeted
  title: Activate your Brave Wallet
  body: Securely Buy, Swap & Explore Web3 with your Brave Wallet!
  targetUrl: https://brave.com/wallet/?campaign=activate&os=ios
debug   14:18:09.649192-0500    Client  Viewed notification ad with placement id fcad579f-614f-4e90-99c0-7b89d6794a87 and creative instance id 05e598c6-a916-4137-b744-14b0b17b602c
debug   14:18:09.656961-0500    Client  Served notification ad with placement id fcad579f-614f-4e90-99c0-7b89d6794a87 and creative instance id 05e598c6-a916-4137-b744-14b0b17b602c
debug   14:18:09.661437-0500    Client  Maybe serve notification ad in 0 hours, 30 minutes, 0 seconds at 14:48:09.660
debug   14:18:09.666731-0500    Client  Successfully logged notification ad served event
debug   14:18:09.668003-0500    Client  Successfully processed deposit for ad_notification with creative instance id 05e598c6-a916-4137-b744-14b0b17b602c and view valued at 0.01
debug   14:18:09.668116-0500    Client  Confirming view for ad_notification with transaction id 164e7940-2f2f-40c5-8aa6-aa69ccd011b9 and creative instance id 05e598c6-a916-4137-b744-14b0b17b602c

After discussing with @kylehickinson, @brave/qa-team we'll need to do the following to view the logs via Console.app as it slightly changed as we're now using the system logger’s.

Verification PASSED on iPad Air (3rd Gen) running iOS 16 using 1.45 (22.11.11.0)

Receiving the expected amount of unblinded tokens as per the following:

debug   14:41:11.263143-0500    Client  GetSignedTokens
debug   14:41:11.263211-0500    Client  GET /v2/confirmation/token/{paymentId}?nonce={nonce}
debug   14:41:11.357137-0500    Client  OnGetSignedTokens
debug   14:41:11.377168-0500    Client  Added 50 unblinded tokens, you now have 50 unblinded tokens
debug   14:41:11.377312-0500    Client  Successfully refilled unblinded tokens

Received an ad notification as per the following

debug   14:42:49.641341-0500    Client  Opportunity arose to serve a notification ad
debug   14:42:49.641736-0500    Client  Found 4 eligible ads
debug   14:42:49.642034-0500    Client  Served notification ad:
  placementId: 6f1b5483-c6b0-428f-842c-b8566b14ab4f
  creativeInstanceId: 6bb3de9a-3cc6-4fe1-ae15-191236db0cbc
  creativeSetId: 9c6959b7-e82c-47ce-b55a-efd79f3534c0
  campaignId: 1df387e5-ed7e-4374-aafe-189526d6b637
  advertiserId: 8fc94bb9-2ab3-49df-a5a7-8ee680384dec
  segment: personal finance
  title: Brave Wallet
  body: Seamlessly explore Web3, without leaving your browser!
  targetUrl: https://brave.com/wallet/?campaign=web3&os=ios
debug   14:42:49.659029-0500    Client  Viewed notification ad with placement id 6f1b5483-c6b0-428f-842c-b8566b14ab4f and creative instance id 6bb3de9a-3cc6-4fe1-ae15-191236db0cbc
debug   14:42:49.668482-0500    Client  Served notification ad with placement id 6f1b5483-c6b0-428f-842c-b8566b14ab4f and creative instance id 6bb3de9a-3cc6-4fe1-ae15-191236db0cbc
debug   14:42:49.672729-0500    Client  Maybe serve notification ad in 0 hours, 30 minutes, 0 seconds at 15:12:49.671
debug   14:42:49.674072-0500    Client  Successfully logged notification ad served event
debug   14:42:49.676911-0500    Client  Successfully processed deposit for ad_notification with creative instance id 6bb3de9a-3cc6-4fe1-ae15-191236db0cbc and view valued at 0.01
debug   14:42:49.677000-0500    Client  Confirming view for ad_notification with transaction id 386e3e37-c3fc-41cd-be8c-c4256b213b94 and creative instance id 6bb3de9a-3cc6-4fe1-ae15-191236db0cbc