brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Playlist play button state out of sync #6441

Open StephenHeaps opened 1 year ago

StephenHeaps commented 1 year ago

Description:

Play button can become out of sync with video play/pause state if tapped before queuing up a video

Steps to Reproduce

Flow 1:

  1. Open playlist with autoplay disabled (Three Dot Menu -> Settings -> Playlist -> Auto-Play) and at least 1 video downloaded
  2. Tap play button in video player
  3. Tap downloaded video in list below
  4. Observe play button showing when video is playing (should be pause button)

Flow 2:

  1. Play a video in Brave Playlist
  2. Switch to music app
  3. Play a song
  4. Video pauses, but if you open Brave again it shows pause button (video paused, should show play).

Actual result:

https://user-images.githubusercontent.com/5314553/202802248-c507327d-59b1-41c9-a788-4d1603cce393.mov

Expected result:

Pause button shows when video is playing

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

Additional Information

StephenHeaps commented 1 year ago

Updated above with a second flow to reproduce button out of sync issue.