brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Open in app is not hiding on google maps website #7024

Closed cuba closed 1 year ago

cuba commented 1 year ago

Description:

The open in app dialogs and buttons are not hiding on google maps

image image

Steps to Reproduce

  1. Enable "Fanboy's Mobile Notifications List" Filter List (wait a moment for the engine to get recompiled)
  2. Go to https://google.com/maps

Actual result:

"Open in app" popup and button is visible

Expected result:

"Open in app" popup and button should not appear

Reproduces how often: [Easily reproduced, Intermittent Issue]

Every time

Brave Version:

1.47

Device details:

Any

Website problems only:

Additional Information

Issue with certain css rules being invalid. Will need further investigation to find out why the invalid css rules are there but for now fixed by cathing with invalid css rules.

Inserting rule: :matches-path(/travel/hotels/) div[data-is-promoted="true"]{display:none !important;} failed: SyntaxError: The string did not match the expected pattern.
Inserting rule: :matches-path(/^/search\?.*tbm=shop/) html[itemtype$="/SearchResultsPage"] #cnt div[class^="_-L"][class*="sh-sr__"]{display:none !important;} failed: SyntaxError: The string did not match the expected pattern.
Uni-verse commented 1 year ago

Verification completed using 1.49 (23.3.31.9) on iPhone X running iOS 16.3.1

Scenario 1: FAILED

  1. Install 1.49.x
  2. Wait a few mins for scripts to load
  3. Navigating to https://www.google.com/maps
  4. Confirm popups are blocked
Example Example
IMG_2882 IMG_2884

Created follow up issue: https://github.com/brave/brave-ios/issues/7188