search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Early migration path testing of Brave Ads on 1.61.42 or above #8301

Closed tmancey closed 10 months ago

tmancey commented 11 months ago

We have transitioned away from plist prefs on iOS to the Chromium pref service. This will resolve many issues concerning default values that never existed on iOS. Can you please test this feature as early as possible to make sure migration paths from legacy versions do not reset Rewards and that users are able to see ads, and confirmation token redemption is successful.

Brave Core PR: https://github.com/brave/brave-core/pull/20460 and https://github.com/brave/brave-core/pull/20626

iccub commented 10 months ago

Hi @tmancey does this require any brave-ios side changes? And if not can you write a test plan here for QA to test

tmancey commented 10 months ago

Test case:

EXPECT RESULT: User should still be opted-in to Brave Rewards

EXPECT RESULT: User should still be opted-in to Brave Rewards

EXPECT RESULT: User should not be opted-in to Brave Rewards

hffvld commented 9 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.2
Brave build: 1.61 (23.12.15.14)
BraveCore: 1.61.102 (120.0.6099.71)

STEPS:

  1. Followed the steps from https://github.com/brave/brave-ios/issues/8301#issuecomment-1832088953

ACTUAL RESULTS:

https://github.com/brave/brave-ios/assets/128532965/4ac1804a-31e4-48f8-b870-ad5713cd8442

1 2
1 2