search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Activity tab not loading NFT images in send transactions #8435

Closed StephenHeaps closed 12 months ago

StephenHeaps commented 1 year ago

Description:

Auto-discovered NFTs will have a logo populated on the BlockchainToken, but manually added NFTs do not. We should fetch metadata and display the NFT image in the Send Transaction row.

Steps to Reproduce

  1. Add an NFT you own manually, not via auto-discovery. The NFT should have an image in NFT tab/grid.
  2. Create a Send transaction for the NFT (you don't have to confirm the transaction)
  3. Visit activity tab and wait for NFT image to show / load. Observe image always displays NFT placeholder icon.

Actual result:

NFT placeholder image is shown

nft image missing in send

Expected result:

NFT image is fetched & shown in send row

Reproduces how often:

Easily reproduced

Brave Version:

v1.61+

Additional Information

Marked as QA/No, will be verified with https://github.com/brave/brave-ios/issues/8349