Fix #8253: Don't navigate to javascript:// URLs from the omnibox - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Fix #8253: Don't navigate to javascript:// URLs from the omnibox #8456

Closed soner-yuksel closed 12 months ago

soner-yuksel commented 12 months ago

Adding isUserDefinedURLNavigation checks to determine if url navigation is should be executed for bookmarklets.

This is caused by https://github.com/brave/brave-ios/pull/8306, in the process of removing visit type

Summary of Changes

This pull request fixes #8453

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Go to any webpage
Type javascript:alert(123) in the url bar
Press enter

Screenshots:

https://github.com/brave/brave-ios/assets/6643505/09ce56d8-03cf-4cf1-8fb5-23917b0e6e0c

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).