brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Accounts tab modals reset when returning from background #8459

Closed StephenHeaps closed 12 months ago

StephenHeaps commented 12 months ago

Description:

Modals presented in the account tab are reset when the app is backgrounded and then user returns from background. This can also occur when using biometrics to fill in password in the Backup Seed Phrase flow.

Steps to Reproduce

Backup modal

  1. Visit Accounts tab
  2. Tap Backup button.
  3. Enter password and toggle the switch then press Continue
    • Alternatively, you can simply use Face ID / Touch ID to reproduce the bug. This technically puts the app into background state, then active state.
  4. Open application switcher to 'background' Brave app.
  5. Bring Brave app back into active state.
  6. Observe Backup flow has been reset to the start / password screen (password field empty, toggle disabled).

Add account modal

  1. Visit Accounts tab
  2. Tap + button.
  3. Tap on any of the coin types to enter a detail view
  4. Open application switcher.
  5. Bring Brave back into foreground
  6. Observe Add Account flow has been reset to the start / coin type selection.

Actual result:

https://github.com/brave/brave-ios/assets/5314553/00bf82ea-10bf-425c-ba4a-f71b90f45032

Expected result:

Modals remain in state they were backgrounded in.

Reproduces how often:

Easily reproduced

Brave Version:

v1.60+ (requires built with Xcode 15 SDK)

Device details:

iOS 17+

Website problems only:

Additional Information

srirambv commented 12 months ago

Verification passed on the following devices running 1.60 (23.11.23.16)

iPhone 13 (iOS 17.2) iPad Pro (iOS 16.7.2) iPhone 7+ (iOS 15.8)