brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Fix #8445: View recovery phrases button is not tappable #8473

Closed nuo-xu closed 11 months ago

nuo-xu commented 12 months ago

Summary of Changes

This issue is caused by the ScrollView has the wrong frame even though screen size is big enough for it to expand. With further investigation, wrong frame caused by keyboard not being dismissed in the previous step which cause SwiftUI thinks the screen height is the actual height minus keyboard height. Attached screenshots below to see the height differences.

This pull request fixes #8445

Submitter Checklist:

Test Plan:

Apparently, only @kdenhartog and I can repro this. I'm adding him as reviewer to see if he can verify.

Screenshots:

When button is not tappable When button is tappable
IMG_3281 IMG_3282

Reviewer Checklist: