brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Fix #8379: Transaction Details v2 UI #8474

Closed StephenHeaps closed 11 months ago

StephenHeaps commented 12 months ago

Summary of Changes

This pull request fixes #8379

Submitter Checklist:

Test Plan:

  1. Make a few different types of transactions; they do not need to be confirmed (though should confirm at least 1 to verify transaction status states).
  2. Open Activity tab and tap on any transaction to open transaction details.
  3. Verify From/To/Transaction Fee rows appear below transaction details.
  4. Verify From/To fields copy button copies the respective address
  5. Confirm at least 1 transaction.
  6. Open transaction details for confirmed transaction.
  7. Verify Transaction Hash row appears. Verify copy button copies tx hash, and link button opens the explorer URL.
  8. Open accounts detail for an account you made a transaction on, verify transactions open using new Transaction Details UI.
  9. Open asset detail for an asset you made a transaction with, verify transactions open using new Transaction Details

Screenshots:

Send NFT - light Send NFT - dark Send ETH - light Send ETH - dark
Approve Value - light Approve Value - dark Approve Unlimited - light Approve Unlimited - dark
Swap - light Swap - dark Solana Swap - light Solana Swap - dark

Reviewer Checklist: