Fix #7877: Fix NightMode applying to elements with a background-image - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Fix #7877: Fix NightMode applying to elements with a background-image #8498

Closed Brandon-T closed 11 months ago

Brandon-T commented 11 months ago

Summary of Changes

Use the computed style instead of a query selector, to determine which elements have a background-image and to invert them.

This pull request fixes #7877

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Screenshots:

Before:

After:

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).