Unloaded NFT image causes the placehodler NFT icon to be bigger than the actual NFT - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Unloaded NFT image causes the placehodler NFT icon to be bigger than the actual NFT #8518

Closed srirambv closed 11 months ago

srirambv commented 11 months ago

Description:

Unloaded NFT image causes the placehodler NFT icon to be bigger than the actual NFT

Steps to Reproduce

Load wallet which has NFT that doesn't show the image
Wait for other NFTs to show image
Check the size of the images

Actual result:

Expected result:

All images should be of the same size

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

Can you reproduce this issue with the most recent build from TestFlight? Yes
Can you reproduce this issue with the previous version of the current build from TestFlight? NA
Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPad (iOS 16.7.2)

Website problems only:

did you check with Brave Shields down? NA
did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @StephenHeaps @nuo-xu

srirambv commented 11 months ago

Verification passed on iPad (iOS 16.7.2) running 1.61(23.12.7.20)

Verified steps from issue description
Verified unloaded NFT image is also of the same size as the loaded one

https://github.com/brave/brave-ios/assets/17010094/48f8be15-7586-473d-a69c-a05f5e4db3c8