NFT shouldn't be refreshed when Network logo setting is toggled - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

NFT shouldn't be refreshed when Network logo setting is toggled #8519

Closed srirambv closed 11 months ago

srirambv commented 11 months ago

Description:

NFT shouldn't be refreshed when Network logo setting is toggled

Steps to Reproduce

Import wallet that has NFTs
Go to NFT tab and wait till all NFTS are fetched
Go to settings and toggle Network logo
NFT gets refreshed every time the toggle is changed

Actual result:

NFT gets refreshed every time the Network toggle is changed

Expected result:

NFT shouldn't be refreshed when Network logo setting is toggled

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

Can you reproduce this issue with the most recent build from TestFlight? Yes
Can you reproduce this issue with the previous version of the current build from TestFlight? NA
Can you reproduce this issue with the current build from AppStore? NA

Device details:

All

Website problems only:

did you check with Brave Shields down? NA
did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @StephenHeaps @nuo-xu

srirambv commented 11 months ago

Verification passed on iPhone 13 with iOS 17.3 running 1.61 (23.12.18.22)

Verified steps from issue description
Verified NFT list isn't refreshed when Network logo setting is toggled

https://github.com/brave/brave-ios/assets/17010094/10f071e5-1bd4-4cba-92e1-110fb4865455