Fix #8518: NFT grid placeholder height is not the same with other grids height - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Fix #8518: NFT grid placeholder height is not the same with other grids height #8524

Closed nuo-xu closed 11 months ago

nuo-xu commented 11 months ago

Summary of Changes

Remove progress view for NFT gif resource
increate skeleton nft loading grids from 6 to 8 so that iPad has loading nft grids filled
Make the nft placeholder image has the same height and width to match other NFT grids

This pull request fixes #8518

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Please refer to the issue.

Screenshots:

New	Old

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).