Fix #8517: Update logic for multi-window on iPhone - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Fix #8517: Update logic for multi-window on iPhone #8531

Closed Brandon-T closed 11 months ago

Brandon-T commented 11 months ago

Summary of Changes

Always restore the first window or active window no matter what. Active window is priority, first window is the fallback.
This ignores the Apple UserActivity that is given to us to "restore" because it can be nil when you kill the app to fast, or perhaps when some other condition happens.

This pull request fixes #8517

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Test session restore on iPhone and iPad.

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).