brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Ref #7835, #8494: Fix handling of External URL when in third-party frames but active tab #8495 #8532

Closed soner-yuksel closed 9 months ago

soner-yuksel commented 9 months ago

Summary of Changes

To use canOpenURL(_:) an Application must declare the URL schemes you pass to this method by adding the LSApplicationQueriesSchemes key to your app's Info.plist file. This method always returns false for undeclared schemes, whether or not an appropriate app is installed.

We are a browser and we have to handle all schemes. Can Open URL is removed from handle external urls. It was added with https://github.com/brave/brave-ios/pull/8495

This pull request fixes #7835 This pull request fixes #8494

Submitter Checklist:

Test Plan:

Check Test Plan and details for https://developer.apple.com/documentation/uikit/uiapplication/1622952-canopenurl

Additionally open a slack link outside the browser and see it works.

Reviewer Checklist: