search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Toggling night mode auto-dismisses menu #8535

Closed StephenHeaps closed 11 months ago

StephenHeaps commented 11 months ago

Description:

Tapping Back to get out of settings after enabling/disabling Night Mode toggle will automatically dismiss the app menu.

Steps to Reproduce

  1. Have >1 open tabs
  2. Tap ..., tap Settings, tap Appearance
  3. Toggle the night mode switch on or off.
  4. Tap back
  5. Tap back again

  6. Observe menu disappears on it's own.

    Alternative STR:

  7. Have >1 open tabs
  8. Tap ... and toggle night mode switch
  9. Observe menu disappears immediately

Actual result:

soner-yuksel commented 11 months ago

Alternative STR

is actually supposed to work this way. After toggling night mode from directly through 3 dot menu, the menu should disappear so it can act like a quick toggle.

But it is this part in the code causing the issue with main STR to reproduce.

hffvld commented 10 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.3
Brave build: 1.62 (24.1.11.20)
BraveCore: 1.62.128 (120.0.6099.144)

STEPS:

  1. Launch Brave > Open 1 tab
  2. Three-dot menu > Settings > Appearance
  3. Toggle the Night Mode switch On or Off
  4. Tap Back > Tap Back again > Verify

ACTUAL RESULTS:

https://github.com/brave/brave-ios/assets/128532965/39ffc957-529a-46b4-9d27-929e2fd566aa