brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Fix #8515: Update SNS interstitial page copy and help page link #8553

Closed nuo-xu closed 11 months ago

nuo-xu commented 11 months ago

Summary of Changes

Copy update and link update

This pull request fixes #8515

Submitter Checklist:

Test Plan:

  1. Make sure Resolve Solana Name Service(SNS) Domain Names is set as Ask
  2. Visit a SNS domain (onybose.sol) in browser
  3. You should see a interstitial page will show up. verify the copy should be the same in the screenshot
  4. Click the help page will redirect you to page https://github.com/brave/brave-browser/wiki/Resolve-Methods-for-Solana-Name-Service
  5. Check Disable and Proceed using an SNS server are still working as expected

A follow up test (need to wait for a core bump that the preference of enabling SNS is set to be Ask) (This can only be verified in 1.62)

  1. Download a older version of Brave Browser with SNS preference feature included
  2. Change that preference to be either Enabled or Disabled NOT Ask
  3. Upgrade the browser to version 1.61
  4. Open wallet/settings to check if SNS preference value is now Ask
  5. repeat the previous test steps.

Screenshots:

Simulator Screenshot - iPhone 15 Pro - 2023-12-12 at 22 12 35

Reviewer Checklist: