brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Fix #8546: Add 1.61 translations. #8557

Closed iccub closed 11 months ago

iccub commented 11 months ago

Summary of Changes

This pull request fixes #8546

Submitter Checklist:

Test Plan:

Verify that the 3dot menu item "security certificate" is translated.

Screenshots:

Reviewer Checklist:

github-actions[bot] commented 11 months ago

[puLL-Merge] - brave/brave-ios@8557

Description

This pull request addresses several translation strings adjustments across different localizations for the Brave Wallet feature. The changes ensure that placeholder texts, disclaimers, interstitial descriptions, and various button and title labels are updated to reflect the appropriate language and context.

Changes ### Changes #### New Entries - `wallet.nftDetailOverview` - Adds a new entry for the overview section in the NFT details screen. - `wallet.nftDetailOwnedBy` - Title for the owner row in the NFT details overview section. - `wallet.nftDetailProperties` - Section header for displaying NFT properties/attributes. - `wallet.transactionApprovalTitle` - Title for ERC20 approvals when the asset is not visibly added. - `wallet.transactionSummaryIntentLabel` - Label for describing transaction type. - `wallet.transactionSummarySolanaSwap` - Label for Solana Swap transactions. - `wallet.transactionSummarySwapOn` - Label for describing swap transactions. - `wallet.unlockWallet` - The title of the unlock wallet button in wallet panel. - `wallet.unlockWalletDescription` - Title displayed on the unlock wallet screen. - `wallet.search` - Placeholder label for search fields. #### Modified Entries - Descriptions on ENS and SNS domain interstitial pages have been revised to clarify the use of third-party services and link to Brave's support page. - In `wallet.transactionSummaryFee`, the fee information has been formatted to have currency and fiat amounts. - Removed navigational title for NFT details screen (`wallet.nftDetailTitle`). ### Security Hotspots There are no direct security-related changes in this pull request. However, ensuring that the URLs provided in the descriptions (e.g., privacy policies and terms of service) are valid and point to the correct resources is key to maintaining trust and security. Additionally, making sure that the third-party services used for .sol domain resolution and other functionalities adhere to Brave's security and privacy standards is important.