Fix #8561: Fix issue with stats script sending empty image sources - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8561: Fix issue with stats script sending empty image sources #8559

Closed cuba closed 9 months ago

cuba commented 9 months ago

Summary of Changes

This pull request fixes #8561

Submitter Checklist:

[ ] Unit Tests are updated to cover new or changed functionality
[ ] User-facing strings use NSLocalizableString()
[ ] New or updated UI has been tested across:
- [ ] Light & dark mode
- [ ] Different size classes (iPhone, landscape, iPad)
- [ ] Different dynamic type sizes

Test Plan:

Enable shields
Go to https://search.brave.com/news?q=test
Scroll down
Check there is no problem while scrolling

Screenshots:

Scrolling should be fast and responsive not like in this video

https://github.com/brave/brave-ios/assets/6643505/177decf2-f20d-4fdf-ac17-c1962fa680b7

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).