brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Allow links to open in external app not working [iOS 16.7] #8563

Open Uni-verse opened 9 months ago

Uni-verse commented 9 months ago

Description:

Opening links in external app not working [iOS 16.7]

Not reproducible on iOS 17 devices

Steps to Reproduce

  1. Install reddit app or any external app from app store on device
  2. Have fresh profile
  3. search for "reddit brave"
  4. click on the reddit link from search results
  5. confirm link opens in reddit external app
  6. Now, disable Allow universal links to open in external apps
  7. click on internal reddit link again
  8. confirm link opens in new tab/ in browser

Actual result:

https://github.com/brave/brave-ios/assets/17885425/a46640ed-f52f-4941-a791-148a86571455

Expected result:

Should open in external app

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily

Brave Version: Any

Device details:

iPhone X iOS 16.7

soner-yuksel commented 9 months ago

This feature works like a blackbox. If user is opened a link in Safari manually it will cache that choice in the OS for instance and not open the app even if there's a universal link for it.

And additionally It may not even be registered with the OS yet if you installed fresh.

Restarting iOS device might help but it is a guarantee.

A very long discussion of this topic can be read https://stackoverflow.com/questions/32751225/ios-universal-links-are-not-opening-in-app.

Seddu commented 9 months ago

I had the same issue in brave. For me, it worked magically by going to reddit in Safari, and then clicking on the top icon where it says 'Open in the reddit app.' Ever since then, all of my reddit links in brave have opened in the Reddit app.