Fix #8552: Reopening closed tabs via Cmd + Shift + T is not working when these tabs are closed using Cmd + W - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8552: Reopening closed tabs via Cmd + Shift + T is not working when these tabs are closed using Cmd + W #8564

Closed soner-yuksel closed 9 months ago

soner-yuksel commented 9 months ago

Summary of Changes

Adding Tab that is closed from key command to recently closed

This pull request fixes #8552

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Open Brave
Open a few tabs
Connect physical keyboard > Use shortcut Cmd + W to close a tab
Now use Cmd + Shift + T to restore closed tab > Observe that tab is not restored

Screenshots:

https://github.com/brave/brave-ios/assets/6643505/fdf572a0-aa0f-448d-b019-682238e9dacd

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).