Fix #8535: Fix toggling night mode

ns-vasilev commented 11 months ago

Summary of Changes

This pull request fixes #8535

[ ] Unit Tests are updated to cover new or changed functionality
[ ] User-facing strings use NSLocalizableString()
[ ] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [ ] Different dynamic type sizes

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).

soner-yuksel commented 11 months ago

@nik3212 Thanks for the contribution and pull request.

Can you make changes according to this comment? There was a confusion there related with behaviour so we can merge this.

ns-vasilev commented 11 months ago

I returned the dismissal closure to NightModeMenuButton and checked if the view is displayed on the screen.

soner-yuksel commented 11 months ago

I returned the dismissal closure to NightModeMenuButton and checked if the view is displayed on the screen.

This seems good now, thanks for contribution.