When blocking document type requests we can intercept them and show a nice error message instead of a blank screen. Later we can add a "continue anyways" button but that is a little more complicated because it requires rewriting content blocker rules and likely some brave core changes if we want to store the exceptions on that side. So I left this out for now.
Could also generalize the CSS (and perhaps even the html) as it follows the latest designs which will need to be used for our other interstitials:
Summary of Changes
This pull request fixes #8096
When blocking
document
type requests we can intercept them and show a nice error message instead of a blank screen. Later we can add a "continue anyways" button but that is a little more complicated because it requires rewriting content blocker rules and likely some brave core changes if we want to store the exceptions on that side. So I left this out for now.Could also generalize the CSS (and perhaps even the html) as it follows the latest designs which will need to be used for our other interstitials:
security review: https://github.com/brave/reviews/issues/1474
Submitter Checklist:
NSLocalizableString()
Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement