search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

"Scan QR Code" from quick action to open a new tab #8594

Closed tomato645 closed 8 months ago

tomato645 commented 9 months ago

Problem Description

Currently, when I use "Scan QR Code" on home screen (quick action), the app opens the URL in existing tab.

Feature Overview

Open the URL from the QR code in a new tab.

Design

Implementation Details

Scan QR code in quick action:

1 Home_screen

Scan QR code in url bar:

URL_bar

User Experience

  1. From quick action -> Open URL in new tab
  2. From search bar -> Same

Additional information

soner-yuksel commented 8 months ago

@tomato645 this makes sense, I also checked other Browser interaction it is aligned with this behaviour.

tomato645 commented 8 months ago

Thank you @soner-yuksel !!!

hffvld commented 7 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4 Beta
Brave build: 1.63 (161)
BraveCore: 1.63.161 (122.0.6261.57)

STEPS:

  1. Follow the steps from https://github.com/brave/brave-ios/pull/8621#issue-2066271706
  2. Verify

ACTUAL RESULTS:

1 2 3
1 2 3

https://github.com/brave/brave-ios/assets/128532965/6ba9879f-750f-4056-8a4a-a22ec1ada087