Closed nuo-xu closed 10 months ago
[puLL-Merge] - brave/brave-ios@8595
This PR adds support for dark and light theme images on iOS as well as refactors some of the views in the BraveWallet
in the Brave iOS app. The change focuses on adding themed images for account and transaction empty states across the application and includes various code updates in Swift files to enhance consistency and maintainability.
No obvious security hotspots are present in the changes. The modifications are primarily related to UI view layout logic and asynchronous data fetching, with no direct security or privacy implications. However, the correctness of data handling during async calls should be carefully reviewed to prevent data races or potential inconsistencies that may misrepresent a user's holdings or transactions.
Order by risk:
Summary of Changes
This pull request fixes #8137
Submitter Checklist:
NSLocalizableString()
Test Plan:
Note: Design mistakenly combine market coin info with other assets. Their information are coming from different source in different data structure with no correlation, thus these two info cannot be put in the same screen. This means, in asset detail, we will have
Acconts
andTransactions
. But market coin detail will have no tabs with some new ui updates.Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement