Fix #8604: Restore Add Custom Token Auto-complete - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8604: Restore Add Custom Token Auto-complete #8605

Closed StephenHeaps closed 8 months ago

StephenHeaps commented 9 months ago

Summary of Changes

Autocomplete / autofill inadvertantly removed in BraveCore v1.63 bump, restored back in this PR using new API supporting all EVM networks.

This pull request fixes #8604

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Open Add Custom Asset view and select the custom assets network (must belong to an EVM), and then paste the contract address of the token. Ex. (SpaceChain token](https://www.coingecko.com/en/coins/spacechain-erc-20).
Verify it loads name, symbol, decimals as expect

Screenshots:

https://github.com/brave/brave-ios/assets/5314553/b7337ac1-40e8-4173-b955-912958fa7648

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).