[hackerone] Fix background tab navigation - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

[hackerone] Fix background tab navigation #8606

Closed stoletheminerals closed 8 months ago

stoletheminerals commented 9 months ago

More details: https://hackerone.com/reports/2302358

hffvld commented 8 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.3
Brave build: 1.62 (24.1.9.23)
BraveCore: 1.62.128 (120.0.6099.144)

STEPS:

Follow the steps from https://github.com/brave/brave-ios/pull/8618#issue-2066074711

ACTUAL RESULTS:

Verified that it opens a new tab with Google but no trigger happens and opens SafariViewController.
Verified the same with Shileds ON and OFF.

Reproduced with build 1.61

https://github.com/brave/brave-ios/assets/128532965/7aab0b4c-7ec6-4a95-906d-d1d82d4c912b

Verified with build 1.62

https://github.com/brave/brave-ios/assets/128532965/6bc9365c-373a-443f-86cb-e9751dd60aad