Fix #8608: Authenticate when disabling browser lock - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Fix #8608: Authenticate when disabling browser lock #8609

Closed Brandon-T closed 10 months ago

Brandon-T commented 10 months ago

Summary of Changes

Fixes: https://hackerone.com/reports/2302346

This pull request fixes #8608

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Turn on Browser Lock (requires system passcode/faceid/touchid)
Turn it off.
It should require authentication to turn it off.

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).

stoletheminerals commented 10 months ago

@Brandon-T can you also add it to this switch?

Brandon-T commented 10 months ago

@Brandon-T can you also add it to this switch?

I did. When you press the switch, it asks for auth.