Fix #8565-8579: Re-enable Screen-Time. - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8565-8579: Re-enable Screen-Time. #8611

Closed Brandon-T closed 8 months ago

Brandon-T commented 9 months ago

Summary of Changes

Enable Screen-Time again.
Instead of setting the URL to about blank, remove the controller from the view.
Fix the order of functions and call the correct functions when doing child controller logic.

This pull request fixes #8565 This pull request fixes #8579

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).