Fix #8374: Cursor is misplaced for a selected URL when that URL doesn't fit the screen - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8374: Cursor is misplaced for a selected URL when that URL doesn't fit the screen #8612

Closed soner-yuksel closed 9 months ago

soner-yuksel commented 9 months ago

Summary of Changes

Selection with text range instead of select all handles tghe case when text is bigger than textfield problems

This pull request fixes #8374

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Launch Brave
Open any website with a long URL, for example, https://www.apple.com/shop/buy-iphone/carrier-offers or https://en.m.wikipedia.org/wiki/National_Organization_for_the_Reform_of_Marijuana_Laws
Tap on the URL search bar > Observe

Screenshots:

https://github.com/brave/brave-ios/assets/6643505/5b05f2c7-9bbb-4da4-8fc3-ab1e0fa92268

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).