Fix #8606: Fix background tab navigation - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8606: Fix background tab navigation #8618

Closed soner-yuksel closed 8 months ago

soner-yuksel commented 8 months ago

Added active Tab check for Safari View Controller presentation for mime type application/x-apple-aspen-config"

Summary of Changes

This pull request fixes #8606

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Open following URL and press exploit hxxps://csrf.jp/2024/mobileconfig/
Check it opens a new tab with goggle but no trigger happens and opens SafariViewController

Screenshots:

https://github.com/brave/brave-ios/assets/6643505/d492257b-8959-48fc-a8dd-249abb25736d

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).