Fix #8619: Send correct ad notification clicked event - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8619: Send correct ad notification clicked event #8620

Closed aseren closed 8 months ago

aseren commented 8 months ago

Summary of Changes

This pull request fixes https://github.com/brave/brave-ios/issues/8619. The bug was introduced here: https://github.com/brave/brave-ios/pull/8386/commits/4184ad9a1e6df8bc04c4fabb66bfb43bfcfb5edb#diff-67a521f6442870976583e55f3c26ea1f2b4fb04e5dc09a237c02c96da86a1a0cR46

Submitter Checklist:

[ ] Unit Tests are updated to cover new or changed functionality
[ ] User-facing strings use NSLocalizableString()
[ ] New or updated UI has been tested across:
- [ ] Light & dark mode
- [ ] Different size classes (iPhone, landscape, iPad)
- [ ] Different dynamic type sizes

Test Plan:

Trigger notification ad
Tap notification ad
Make sure that the clicked event was fired

Screenshots:

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).