Fix #8594: "Scan QR Code" from quick action to open a new tab - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8594: "Scan QR Code" from quick action to open a new tab #8621

Closed soner-yuksel closed 8 months ago

soner-yuksel commented 8 months ago

Open New tab when Scan QR code is executed from quick long press action

Summary of Changes

This pull request fixes #8594

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Long Press Icon Scan a QR Code Check new tab opened before scan screen is shown

Screenshots:

https://github.com/brave/brave-ios/assets/6643505/e3d18e79-259e-4e67-9d17-f5d41213cc6b

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).