brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Fix #8070: Support 'Clean Copy Link' from Sharesheet #8626

Closed soner-yuksel closed 10 months ago

soner-yuksel commented 10 months ago

Summary of Changes

Adding copy clean link to share sheet activity list

This pull request fixes #8070

Submitter Checklist:

Test Plan:

  1. Click on the share button both from bottomtool bar and settings
  2. Sharesheet is displayed with 'Copy Clean Link' option
  3. Clicks on option in sharesheet and has the link with tracking params stripped copied to keyboard

Screenshots:

https://github.com/brave/brave-ios/assets/6643505/59ff6022-5da8-44f6-8bf2-80cd22bffe0a

Reviewer Checklist:

github-actions[bot] commented 10 months ago

[puLL-Merge] - brave/brave-ios@8626

Description

This pull request removes several activities related to sharing and managing web content and adds a new makeShareActivities method and presentActivityViewController method to handle web content sharing activities within BrowserViewController.

Changes ### Changes - Removed `makeShareActivities` and `presentActivityViewController` from `BrowserViewController` - Added `makeShareActivities` and `presentActivityViewController` to `BrowserViewController` - Removed several activity classes related to sharing and managing web content

Security Hotspots

No security hotspots identified in this change.