brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8635: URLBar updates and CertValidation #8634

Closed Brandon-T closed 8 months ago

Brandon-T commented 8 months ago

Summary of Changes

Update URL bar on cancellation instead of URL change, because URL change can update the certificate state and URL spoofing is possible.
Remove didCommit serverTrust validation as it works fine with URLBar Revamp.
Make the validation function async-await
Remove select as it crashes in debug builds

This pull request fixes #8635 and This pull request fixes #8393 This pull request fixes #7403 This pull request fixes #8576

8393 #7403 #8576 has to be re-tested.

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Re-test all the linked tickets

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).