Intermittent Incorrect URL Bar state and various fixes related with state and url

[soner-yuksel]

Description:

URL Bar update moved to didFailProvisionalNavigation to support spoofing prevention properly. For cancelation didFailProvisionalNavigation should be used.

This way we can cover both cancelation url update problem and also blank address bar before loading starts.

Issues closed related with this were

https://github.com/brave/brave-ios/issues/8393 https://github.com/brave/brave-ios/issues/8576

Also the async trigger for observe webview key values inside didCommit is removed. In addition verifyTrust is forced to run async and the awaited result is used on updateURL bar.

We are thinking these 2 changes will solve the intermittent problem related with loading urls stuck in insecure state.

In addition this change also should be tested where we show secure icon when insecure website is loaded.

https://github.com/brave/brave-ios/issues/7403

Test Plan

Test all the STRs in these 3 tickets, fresh test all over again.

https://github.com/brave/brave-ios/issues/8393 https://github.com/brave/brave-ios/issues/8576 https://github.com/brave/brave-ios/issues/7403

In addition always keep an eye on if a insecure website indicator shown on a secure website.

[Uni-verse]

Verified on iPhone 12 Pro running iOS 17.1.1 using version 1.62 (24.1.11.20)

• Verified test plan in https://github.com/brave/brave-ios/issues/8393
• Verified test plan in https://github.com/brave/brave-ios/issues/8576
• Verified test plan in https://github.com/brave/brave-ios/issues/7403
• Verified warning icon is shown in the URL bar for insecure sites (HTTP).
• Verified warning icon is not shown while loading websites (HTTPS).

Example	Example	Example	Example	Example	Example