brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

SSL Error shows on interstitial pages #8650

Closed Brandon-T closed 8 months ago

Brandon-T commented 8 months ago

Description:

Steps to Reproduce

  1. Test http://neverssl.com
  2. Test turning off internet on any page and refreshing it until you get the "No internet connection" interstitial page

Actual result:

  1. Shows "Warning" instead of "Insecure"
  2. Shows "Insecure" instead of "Secure"

Expected result:

  1. Should show "Insecure"
  2. Should show "Secure"

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

Uni-verse commented 8 months ago

Verified on iPhone X running iOS 16.7 using version 1.62 (24.1.29.12)

Test Steps: https://github.com/brave/brave-ios/issues/8650#issue-2079688125

Fresh Profile

  1. Navigate to http://neverssl.com.
  2. Confirm warning message shows Not Secure.
  3. Tap on the warning message.
  4. Disable internet and reload the page.
  5. Confirm warning message shows a secure connection (no warning message).
Example Example Example
IMG_3711 IMG_3713 IMG_3712

Upgraded Profile (1.61.1 -> 1.62)

  1. Install 1.61.1 app version.
  2. Navigate to http://neverssl.com.
  3. Confirm warning message is shown in URL bar.
  4. Disable internet on device and reload the page.
  5. Confirm Not Secure message is shown.
  6. Enable internet on device, reload page.
  7. Upgrade to 1.62.
  8. Check message in URL bar.
  9. Repeat Step 4-6
1.61.1 1.62
IMG_3714 IMG_3712