Closed StephenHeaps closed 8 months ago
[puLL-Merge] - brave/brave-ios@8654
This pull request makes several changes to the SendTokenView.swift
, SelectAccountTokenView.swift
, SelectAccountTokenStore.swift
, RpcServiceExtensions.swift
, and SelectAccountTokenStoreTests.swift
files. The changes include updates to the way token stores are selected and updated, improvements to fetching account and asset information, modifications to the handling of balances, and changes related to network filtering.
Summary of Changes
SelectAccountTokenStore
would build all account sections with all tokens, and use a computed property to filter out networks (from network filters) and tokens without balance. This would be expensive on the UI, so now the models are built once when network filters change, query changes, or user taps Show/Hide Zero Balances button. These models are built off the main thread using an async function for a bit extra perf with large accounts/token lists.This pull request fixes #8649
Submitter Checklist:
NSLocalizableString()
Test Plan:
Unfortunately I did not find consistent reproduce steps for the UI lockup, so hard to verify the lockup but we should test view is still working as before (use a wallet with lots of accounts and tokens with balance):
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement