Fix #7611: Add first party list to iOS - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Fix #7611: Add first party list to iOS #8655

Closed cuba closed 9 months ago

cuba commented 10 months ago

Summary of Changes

This pull request fixes #7611

Won't compile without https://github.com/brave/brave-core/pull/21582

Submitter Checklist:

[ ] Unit Tests are updated to cover new or changed functionality
[ ] User-facing strings use NSLocalizableString()
[ ] New or updated UI has been tested across:
- [ ] Light & dark mode
- [ ] Different size classes (iPhone, landscape, iPad)
- [ ] Different dynamic type sizes

Test Plan:

TBD

Screenshots:

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).

cuba commented 9 months ago

using list catalog instead of this