search

brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

Webcompat reporter sending internal://local URL instead of correct one #8667

Closed ShivanKaul closed 7 months ago

ShivanKaul commented 8 months ago

Description:

We're getting several internal://local URLs on the webcompat reporter backend. This points towards a bug on the client-side, since an internal URL doesn't help us fix Shields issues. The two cases where this seems to be happening is:

  1. User is in Reader mode
  2. User is on an error page

Interestingly, if I go through hamburger menu to report the site, the URL shows up correctly.

Steps to Reproduce

  1. Start Reader mode on a website like https://www.themediterraneandish.com/shakshuka-recipe/
  2. Shields down
  3. Report site

Can also repro by going to a website and turning off wifi/data, in which case the URL shows up as internal://local/errorpage

Actual result:

IMG_9865

Expected result:

IMG_9867

hffvld commented 7 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4 Beta
Brave build: 1.63 (161)
BraveCore: 1.63.161 (122.0.6261.57)

STEPS:

  1. Launch Brave
  2. Go to https://chromeunboxed.com or https://www.themediterraneandish.com/shakshuka-recipe/, for example
  3. Open any article > Enable Reader Mode
  4. Brave Shields > Disable shields
  5. Tap Report a Broken Site > Verify

ACTUAL RESULTS:

1 2 3 4
1 2 3 4