Fix #8658: Tab bar interaction is broken after it becomes visible - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

Fix #8658: Tab bar interaction is broken after it becomes visible #8669

Closed nik3212 closed 6 months ago

nik3212 commented 8 months ago

Summary of Changes

This pull request fixes brave/brave-browser#36591

Submitter Checklist:

[ ] Unit Tests are updated to cover new or changed functionality
[ ] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Screenshots:

https://github.com/brave/brave-ios/assets/17319991/7f25ee28-f71e-452a-8905-40d6059eb440

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).

kylehickinson commented 6 months ago

thanks @nik3212 but it looks like this is no longer an issue and may have been fixed at some point with some other change. Closing this as its no longer needed